AnalyzeView: Add Exiv2 for writing exif data #11906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-analyzeview-exif
branch
3 times, most recently
from
aadb042
to
d5f715a
Compare
HTRamsey
force-pushed
the
dev-analyzeview-exif
branch
from
d5f715a
to
5c7dc21
Compare
|
So readtime2 might be switched over to if testing proves it out? |
Yeah, I can remove it now but I also intend to come back to exif stuff soon and expand a bit on it, so I can do it then too. Easyexif is just much easier to work with and is a very small lib but it only reads data. I did this mostly because there's a bug in the writing section that is causing my geotag PR's unit tests to fail |
DonLakeFlyer
approved these changes
Sep 21, 2024
all good then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Exif Writing by adding Exiv2 dependency. This also allows much more capabilities in regards to geotagging too. Not sure whether to remove easyexif or not, at least until this has been more thoroughly tested.